Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM/SgiPkg: fix build failure on SgiPlatformMm #248

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

vbpandya
Copy link
Contributor

@vbpandya vbpandya commented Nov 18, 2024

commit 8bc44608b8ea ("MdeModulePkg: Add ImagePropertiesRecordLib") makes build fail. This patch adds ImpagePropertiesRecordLib and related libraries to fix the build.

@vbpandya vbpandya marked this pull request as ready for review November 18, 2024 18:43
@samimujawar
Copy link
Contributor

@vbpandya Thank you for this fix.
The change-ID needs to be dropped, otherwise this patch looks good to me.

@vbpandya vbpandya closed this Nov 19, 2024
@vbpandya vbpandya force-pushed the fix_build_sgiplatmm branch from 18423ab to 4b3530d Compare November 19, 2024 21:08
@vbpandya vbpandya reopened this Nov 19, 2024
@vbpandya vbpandya force-pushed the fix_build_sgiplatmm branch from 555cbc5 to 3d717e5 Compare November 19, 2024 21:36
@vbpandya
Copy link
Contributor Author

@vbpandya Thank you for this fix. The change-ID needs to be dropped, otherwise this patch looks good to me.

Thank you for catching that Sami!
Updated accordingly.

commit 8bc44608b8ea ("MdeModulePkg: Add ImagePropertiesRecordLib") makes
build fail. This patch adds ImpagePropertiesRecordLib and related
libraries to fix the build.

Signed-off-by: VarshitPandya <[email protected]>
@vbpandya vbpandya force-pushed the fix_build_sgiplatmm branch from 3d717e5 to 151bebd Compare November 20, 2024 11:52
Copy link
Contributor

@samimujawar samimujawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

@samimujawar samimujawar merged commit f10cc76 into tianocore:master Nov 22, 2024
1 check passed
abdattar pushed a commit to abdattar/edk2-platforms that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants