Various Arm platforms: minor Pcd cleanup #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles These platforms all set PcdRelocateVectorTable to its default value of FALSE. Since the Pcd is getting dropped in edk2, skip the setting here. Signed-off-by: Leif Lindholm <[email protected]>
PcdCpuVectorBaseAddress was never used, since PcdRelocateVectorTable was always seto to FALSE. However, now the Pcd is getting dropped from edk2, so get ridd of the bogus setting. Signed-off-by: Leif Lindholm <[email protected]>
leiflindholm
requested review from
ardbiesheuvel,
ndhillonm,
wojtas-marcin,
samimujawar,
nhivp,
bexcran,
chuongtranle,
abdattar,
changab and
pbgrimes
as code owners
ardbiesheuvel
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PcdRelocateVectorTable was explicitly set to FALSE (the default value) for several platforms.
Additionally, BeagleBoard/Omap set a value for PcdCpuVectorBaseAddress which was never used because PcdRelocateVectorTable was set to false.
Get rid of these bogus Pcd settings before dropping the Pcds in edk2.