-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff: require function annotations #609
Merged
Javagedes
merged 13 commits into
tianocore:master
from
Javagedes:add-function-annotations
Jan 18, 2024
Merged
ruff: require function annotations #609
Javagedes
merged 13 commits into
tianocore:master
from
Javagedes:add-function-annotations
Jan 18, 2024
+714
−514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57f17d1
to
0a3d3de
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 78.73% 78.52% -0.21%
==========================================
Files 49 49
Lines 4853 4909 +56
==========================================
+ Hits 3821 3855 +34
- Misses 1032 1054 +22
|
daea96e
to
5c2e3d8
Compare
spbrogan
approved these changes
Jan 11, 2024
Adds the rule ANN which requires function annotations. See https://beta.ruff.rs/docs/rules/#flake8-annotations-ann for more information.
Adds the rule ANN which requires function annotations. See https://beta.ruff.rs/docs/rules/#flake8-annotations-ann for more information.
c937a39
to
f4856a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the rule ANN which requires function annotations. See https://beta.ruff.rs/docs/rules/#flake8-annotations-ann for more information.
Only adds type annotations to function headers so this will have no effect on the codebase itself.
This is the edk2-pytool-extensions portion of completing this issue: tianocore/edk2-pytool-library#208