Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: require function annotations #609

Merged
merged 13 commits into from
Jan 18, 2024

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Jul 14, 2023

Adds the rule ANN which requires function annotations. See https://beta.ruff.rs/docs/rules/#flake8-annotations-ann for more information.

Only adds type annotations to function headers so this will have no effect on the codebase itself.

This is the edk2-pytool-extensions portion of completing this issue: tianocore/edk2-pytool-library#208

@Javagedes Javagedes added the enhancement New feature or request label Jul 14, 2023
@Javagedes Javagedes added this to the v0.23.10 milestone Jul 14, 2023
@Javagedes Javagedes self-assigned this Jul 14, 2023
@Javagedes Javagedes requested a review from makubacki July 14, 2023 20:51
@Javagedes Javagedes force-pushed the add-function-annotations branch 2 times, most recently from 57f17d1 to 0a3d3de Compare July 17, 2023 16:40
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3bcbe28) 78.73% compared to head (f4856a3) 78.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   78.73%   78.52%   -0.21%     
==========================================
  Files          49       49              
  Lines        4853     4909      +56     
==========================================
+ Hits         3821     3855      +34     
- Misses       1032     1054      +22     
Files Coverage Δ
edk2toolext/base_abstract_invocable.py 80.00% <100.00%> (ø)
edk2toolext/capsule/capsule_tool.py 62.50% <100.00%> (+0.59%) ⬆️
edk2toolext/capsule/signing_helper.py 86.95% <100.00%> (+0.59%) ⬆️
edk2toolext/capsule/signtool_signer.py 56.81% <100.00%> (ø)
edk2toolext/edk2_invocable.py 74.31% <100.00%> (-1.10%) ⬇️
edk2toolext/edk2_logging.py 88.52% <100.00%> (+0.06%) ⬆️
edk2toolext/environment/conf_mgmt.py 100.00% <100.00%> (ø)
...oolext/environment/environment_descriptor_files.py 83.92% <100.00%> (ø)
...ronment/extdeptypes/az_cli_universal_dependency.py 43.47% <100.00%> (ø)
...2toolext/environment/extdeptypes/git_dependency.py 98.30% <100.00%> (ø)
... and 25 more

@Javagedes Javagedes modified the milestones: v0.23.10, v0.23.11 Jul 28, 2023
@Javagedes Javagedes modified the milestones: v0.24.0, v0.24.1 Aug 21, 2023
@Javagedes Javagedes modified the milestones: v0.24.1, 0.24.2 Oct 2, 2023
@Javagedes Javagedes modified the milestones: 0.25.1, 0.25.2 Oct 20, 2023
@Javagedes Javagedes modified the milestones: 0.26.0, 0.26.1 Nov 6, 2023
@Javagedes Javagedes modified the milestones: 0.26.1, 0.26.3 Nov 13, 2023
@Javagedes Javagedes force-pushed the add-function-annotations branch from daea96e to 5c2e3d8 Compare December 8, 2023 19:12
@Javagedes Javagedes modified the milestones: 0.26.3, 0.26.4 Dec 18, 2023
@Javagedes Javagedes force-pushed the add-function-annotations branch from c937a39 to f4856a3 Compare January 18, 2024 16:46
@Javagedes Javagedes merged commit ba5b0d6 into tianocore:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants