Only restore file permissions on Linux #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 78.73% 77.56% -1.18%
==========================================
Files 49 49
Lines 4852 4853 +1
==========================================
- Hits 3820 3764 -56
- Misses 1032 1089 +57
|
makubacki
approved these changes
Dec 14, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file permissions issue that was fixed via #608 was specifically targeting Linux systems (as seen in the tests, that only test for Linux), however the permissions fix-up was applied regardless of operating system. This change ensures that the fixup is only applied on Non windows systems.