Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyopenssl_signer: Use cryptography #918

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Jan 6, 2025

per pyopenssl deprecation notice, the crypto module is being deprecated. Per the pyopenssl documentation, the cryptography module is the recommended replacement. This commit updates the pyopenssl_signer to use the cryptography module.

This deprecation was discovered as Ubuntu-24.04 images are missing the crypto module.

https://www.pyopenssl.org/en/stable/api/crypto.html

@Javagedes Javagedes force-pushed the pyopenssl-deprecated branch 3 times, most recently from 84a0c76 to cb20250 Compare January 6, 2025 17:14
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.79%. Comparing base (bf643b0) to head (cb4ef31).
Report is 120 commits behind head on master.

Files with missing lines Patch % Lines
edk2toolext/capsule/pyopenssl_signer.py 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   78.75%   78.79%   +0.03%     
==========================================
  Files          49       41       -8     
  Lines        4909     5055     +146     
==========================================
+ Hits         3866     3983     +117     
- Misses       1043     1072      +29     
Files with missing lines Coverage Δ
edk2toolext/capsule/pyopenssl_signer.py 69.04% <75.00%> (-2.01%) ⬇️

... and 48 files with indirect coverage changes

@Javagedes Javagedes requested review from Flickdm and apop5 January 6, 2025 17:23
per pyopenssl deprecation noteice, the crypto module is being
deprecated. Per the pyopenssl documentation, the cryptography module is
the recommended replacement. This commit updates the pyopenssl_signer
to use the cryptography module.
@Javagedes Javagedes force-pushed the pyopenssl-deprecated branch from cb20250 to cb4ef31 Compare January 6, 2025 17:50
@Javagedes Javagedes merged commit 94d2fda into tianocore:master Jan 6, 2025
24 of 25 checks passed
@Javagedes Javagedes added this to the v0.28.1 milestone Jan 6, 2025
@Javagedes Javagedes added the enhancement New feature or request label Jan 6, 2025
@Javagedes Javagedes self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants