Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust.py: Use cargo-binstall #929

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Javagedes
Copy link
Contributor

There have been too many instances of issues manually installing cargo-make. These issues occur because cargo-make does not upload a Cargo.lock file for releases, and our rust repositories always being on an old rust version. This results in the latest versions of some crates being pulled in, which may have their minimum supported version of rust higher than the version we use.

To improve the user experience, lets just have the user install the binaries instead of attempting to compile.

There have been too many instances of issues manually installing
cargo-make. These issues occur because cargo-make does not upload a
Cargo.lock file for releases, and our rust repositories always being on
an old rust version. This results in the latest versions of some crates
being pulled in, which may have their minimum supported version of rust
higher than the version we use.

To improve the user experience, lets just have the user install the
binaries instead of attempting to compile.
@Javagedes Javagedes requested a review from makubacki January 30, 2025 20:22
@Javagedes Javagedes changed the title rust_build.md: Use cargo-binstall rust.py: Use cargo-binstall Jan 30, 2025
@Javagedes Javagedes requested a review from apop5 January 30, 2025 20:30
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (bf643b0) to head (b6b6019).
Report is 127 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   78.75%   78.79%   +0.03%     
==========================================
  Files          49       41       -8     
  Lines        4909     5055     +146     
==========================================
+ Hits         3866     3983     +117     
- Misses       1043     1072      +29     
Files with missing lines Coverage Δ
edk2toolext/environment/rust.py 86.56% <ø> (ø)

... and 49 files with indirect coverage changes

@Javagedes Javagedes added this to the v0.28.1 milestone Jan 30, 2025
@Javagedes Javagedes merged commit bd13a66 into tianocore:master Jan 31, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants