Skip to content

Avoid forced copy in step_setnames() and rename_with() #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid forced copy in step_setnames() and rename_with() #486

wants to merge 1 commit into from

Conversation

tinygreen
Copy link

step_setnames() and rename_with() will now not force a copy() if lazy_dt() was called with immutable = FALSE. In line with how mutate() and relocate() already behave.

Added test for rename() with immutable = FALSE. Updated expected result of pivot_wider() test, as the call to step_setnames() triggered an unnecessary copy() there too, which is now also avoided.

Fixes #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename() and rename_with() trigger copy() despite immutable = FALSE
1 participant
@tinygreen