change geom_vline and geom_hline inherit.aes parameter default to NULL#6836
Open
EvaMaeRey wants to merge 2 commits intotidyverse:mainfrom
Open
change geom_vline and geom_hline inherit.aes parameter default to NULL#6836EvaMaeRey wants to merge 2 commits intotidyverse:mainfrom
EvaMaeRey wants to merge 2 commits intotidyverse:mainfrom
Conversation
arcresu
reviewed
Apr 13, 2026
| inherit.aes = FALSE) { | ||
| inherit.aes = NULL) { | ||
|
|
||
| # if NJLL default is based on if xintercept is missing |
Contributor
There was a problem hiding this comment.
Suggested change
| # if NJLL default is based on if xintercept is missing | |
| # if NULL, default is based on whether xintercept is missing |
(And same below).
Contributor
|
I wonder whether the docs should also be updated to explain how the behaviour changes based on |
Collaborator
|
Gina does this PR aim to fix #6831? |
Contributor
Contributor
Author
EvaMaeRey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.