core: avoid getting region twice #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9079 +/- ##
==========================================
+ Coverage 76.20% 76.21% +0.01%
==========================================
Files 468 468
Lines 71471 71455 -16
==========================================
- Hits 54462 54461 -1
+ Misses 13595 13584 -11
+ Partials 3414 3410 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
nolouch
approved these changes
Feb 14, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
bufferflies
approved these changes
Feb 17, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
rleungx
force-pushed
the
avoid-get-again
branch
from
26229f1 to
fd217a1
Compare
ti-chi-bot
bot
added
size/S
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #4399
What is changed and how does it work?
Check List
Tests
Release note