Skip to content

Conversation

@agren
Copy link
Member

@agren agren commented Oct 30, 2025

Description

Castor has new USB VID and PID. This PR adds a new udev rule for it.

I've checked that the new udev rule works with a TKey built from main (tillitis/tillitis-key1@ea82b0c)

Related to PR tillitis/tkey-devtools#19

Type of change

  • Feature (non breaking change which adds functionality)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

Copy link
Member

@mchack-work mchack-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Arch by first removing all TKey related rules, then adding this rule to /etc/udev/rules.d, running tkey-runapp. Works fine on both Castor and Bellatrix.

Grumpy old man MC thinks it's a little unnerving that the device file's permissions stays the same, though, and all the special permissions for the uaccess tag et cetera are kept in the udev database. What's wrong with everything being a file? Plan 9 was right!

@agren agren merged commit e92e5b8 into main Oct 31, 2025
7 checks passed
@agren agren deleted the castor-vid-pid branch October 31, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants