Open
Conversation
When user doesn’t have write permissions in pyglow directory, look for common linux, windows, and osx temp directory environment variables and write to these instead.
Merge pull request timduly4#22 from aburrell/profile
Untested update where Point inherits from Profile
Write files to tempdir
Added ignores for *.pyc, *~, mtime_table.pkl, and geophysical_indices.npy
Tested version of Point, with updated README
Collaborator
|
This is a very old PR but it may still be merge-able. It would be great to have a "vectorized" version to work with. Thoughts? |
Author
|
It'd be good to at least get this off of my fork and into the main repository as a branch. Discussion as to whether or not it should be merged into develop/main could go forward after that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted Point class to inherit from Profile, removing duplicate routine calls.
Secondary adjusts:
Follow updated README to test: