fix(tests): de-flake grouping E2E against interleaved incident lines#375
Merged
Merged
Conversation
The grouping alert-pipeline test posts two detections that group into one incident and asserts both pass-through lines carry the same incident_id. Because group_wait is 0s, the 1s alert tick also emits a group_wait incident to the same file sink; that line carries a top-level incident_id rather than one under enrichments and can interleave between the two detections. Selecting file lines by the enrichments.incident_id annotation makes the assertion independent of incident-emission ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grouping_annotates_incident_id_and_exposes_open_incidentsposts two detections that group into one incident and asserts the first two file-sink lines are both pass-through detections carryingenrichments.incident_id.group_wait: 0s, the daemon's 1s alert tick emits agroup_waitincident to the same file sink. That line carries a top-levelincident_id(not one underenrichments) and can interleave between the two detections, solines[1]was sometimes the incident line, trippingsecond detection must carry incident_id.enrichments.incident_idannotation, so the assertion no longer depends on incident-emission ordering. Test-only change; daemon behavior is unchanged.Test plan
cargo test -p rsigma-cli --features daemon --test cli_daemon_alert_pipeline(all 5 pass)grouping_annotates_incident_id_and_exposes_open_incidents5 times in a row with no failurescargo fmt --all -- --check