Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix Header click behaviour #2815

Merged
merged 2 commits into from
Jan 31, 2025
Merged

🐛Fix Header click behaviour #2815

merged 2 commits into from
Jan 31, 2025

Conversation

joshbermanssw
Copy link
Member

Fixed the doc and blog scroll behaviour by using an offset and the window.scrollTo() function to custom set our offset from the "top of the page"

https://github.com/user-attachments/assets/0a2c14ae-5fc4-4afd-8770-0235fbe150d7
Figure: New Scroll Behaviour

@joshbermanssw joshbermanssw requested a review from a team as a code owner January 31, 2025 01:06
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:15am

Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshbermanssw joshbermanssw merged commit e72536f into main Jan 31, 2025
4 checks passed
@joshbermanssw joshbermanssw deleted the fix-header-rendering branch January 31, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants