Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 drop height of left-hand-container to fix scroll height #2816

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

joshbermanssw
Copy link
Member

As per #2790

I have dropped the height of the LeftHandSideParentContainer so that it doesnt hug the bottom of the page when the user is scrolling down the page. See video

Screen.Recording.2025-01-31.at.12.43.31.pm.mov

Figure: Left hand bar doesnt hug bottom anymore

@joshbermanssw joshbermanssw requested a review from a team as a code owner January 31, 2025 01:48
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 3:26am

@joshbermanssw joshbermanssw changed the title drop height of left-hand-container to fix scroll height 🐛 drop height of left-hand-container to fix scroll height Jan 31, 2025
Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bug hunt

@joshbermanssw joshbermanssw merged commit 1cbbe9a into main Jan 31, 2025
4 checks passed
@joshbermanssw joshbermanssw deleted the fix-left-hand-sidebar branch January 31, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants