fix: make result waits abortable - #159
Merged
Merged
Conversation
15wtyuan
pushed a commit
to 15wtyuan/pi-subagents
that referenced
this pull request
Jul 24, 2026
Resolved conflicts: - CHANGELOG.md: keep our [Unreleased] block above upstream's [0.14.3] - README.md: keep SessionView description, adopt upstream tintinweb#155 ●/○ markers - src/ui/fleet-list.ts: keep renderFleetBar delegation (dropped inline dup) - src/ui/fleet-roster.ts: adopt tintinweb#155 ●/○ selected/unselected markers - src/index.ts: keep resolve() name-lookup + adopt upstream tintinweb#159 abortable signal in get_subagent_result; cancelNudge uses record.id - test/fleet-list.test.ts: keep SessionView tests, drop obsolete ConversationViewer cursor-follow + steer-composer tests (viewer deleted in Task 9) Tests: 733 passed / 23 failed (all pre-existing Windows-env artifacts; 0 new regressions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158.
Summary
get_subagent_result(wait: true)against the tool-callAbortSignalwithout forwarding cancellation to the background childEscbehavior and cover running, queued, notification, child-survival, and listener-cleanup behavior through the registered toolVerification
npm run lintnpm run typechecknpm run buildnpm run test(733 passed, 5 skipped)git diff --check