Skip to content

fix(ui): show effective subagent runtime model - #168

Open
xz-dev wants to merge 6 commits into
tintinweb:masterfrom
xz-dev:fix/show-effective-agent-model
Open

fix(ui): show effective subagent runtime model#168
xz-dev wants to merge 6 commits into
tintinweb:masterfrom
xz-dev:fix/show-effective-agent-model

Conversation

@xz-dev

@xz-dev xz-dev commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • retain the effective canonical provider/modelId for Agent UI rendering, including inherited and scheduled runs
  • pair it with the child session's actual thinking level after Pi applies defaults and model capability clamping
  • show that runtime metadata in running, queued, and finished Agent widgets, collapsed and expanded Agent results, and ConversationViewer
  • keep resumed Agent results bound to the existing child session's current runtime metadata
  • keep model identifiers safe for single-line terminal rendering

Why

A thinking level such as max has little meaning without the model it applies to. The UI previously hid the model whenever a subagent inherited the parent model, and several background paths still omitted it entirely. Some paths also displayed requested configuration rather than the child session's effective model and thinking level.

The runtime Agent session is now authoritative once it exists. Before session creation, the immediate background result truthfully shows the resolved pre-session model metadata; later views read the live session state.

Tests

  • npm run lint
  • npm run typecheck
  • npm run test — 828 passed, 5 skipped
  • npm run build

Coverage includes foreground/background Agent results, running/queued/finished AgentWidget rows, scheduled Agent metadata, ConversationViewer live runtime state, and resume after the existing session model/thinking changes.

@xz-dev xz-dev changed the title fix(ui): show effective subagent model IDs fix(ui): show model with subagent thinking level Jul 23, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 23, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 23, 2026
@xz-dev
xz-dev force-pushed the fix/show-effective-agent-model branch from f927760 to 8f83829 Compare July 27, 2026 00:15
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 27, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 27, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 29, 2026
@stanleytejakusuma

Copy link
Copy Markdown

hit this exact issue independently. spawned several background subagents configured on the same model as the parent session, but the running agent silently omitted the model name directly. so there's no way to tell what was actually driving a given subagent from the widget alone.

would genuinely like to see this merged - thanks for the fix!

@xz-dev
xz-dev force-pushed the fix/show-effective-agent-model branch from 8f83829 to ba300a4 Compare July 31, 2026 04:34
xz-dev pushed a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 31, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 31, 2026
@xz-dev
xz-dev force-pushed the fix/show-effective-agent-model branch from ba300a4 to 562021c Compare August 2, 2026 16:21
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Aug 2, 2026
@xz-dev xz-dev changed the title fix(ui): show model with subagent thinking level fix(ui): show effective subagent runtime model Aug 4, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Aug 4, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants