fix(ui): render Agent tool errors verbatim - #195
Open
xz-dev wants to merge 1 commit into
Open
Conversation
Use Pi’s public render context to distinguish invocation failures from structured Agent lifecycle results. Fall back to result text for missing or unknown details instead of inferring a max-turn abort.
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Aug 2, 2026
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Aug 4, 2026
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolRenderContext.isErroras their actual result textPreviously, an error result with
details: {}could fall through to the terminal-status branch and displayAborted (max turns exceeded)instead of the real startup error.Tests
npx vitest run test/agent-tool-error-rendering.test.ts— 4 passednpm run lintnpm run typechecknpm run test— 823 passed, 5 skippednpm run buildIndependent review: C0/I0/M0.