Skip to content

Perhaps fix an overflow bug relate to timer #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Perhaps fix an overflow bug relate to timer #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e53bf9f
fix an overflow bug, which causes overflow task to execute and all o…
yulincoder Jul 14, 2018
0f276fc
Initial WhiteSource configuration file
Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .whitesource
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
##########################################################
#### WhiteSource Integration configuration file ####
##########################################################

# Configuration #
#---------------#
ws.repo.scan=true
vulnerable.check.run.conclusion.level=failure
10 changes: 10 additions & 0 deletions tos/lib/timer/VirtualizeTimerC.nc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ implementation
runtime cost). */
uint32_t now = call TimerFrom.getNow();
int32_t min_remaining = (1UL << 31) - 1; /* max int32_t */
int32_t max_int32 = min_remaining;
bool min_remaining_isset = FALSE;
uint16_t num;

Expand All @@ -119,6 +120,15 @@ implementation
uint32_t elapsed = now - timer->t0;
int32_t remaining = timer->dt - elapsed;

/* If the value of timer's destination greater than max int32_t,
then the virtual timer is ignored to avoid the fact that all
of other tasks is hard to get runing time and the battery is
quickly exhausted. And the system may crash.*/
if(timer->dt > max_int32) {
dbg("Value error", "The timer's destination value is too high\n");
continue;
}

if (remaining < min_remaining)
{
min_remaining = remaining;
Expand Down