Fix workflow caching, disable fail-fast #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflow caching was not working as intended, fail-fast caused fail of all jobs when one build failed Signed-off-by: Vdragon <[email protected]>
|
That teaches me some CI-fu in the process. The issue we face (all failing) looks like what you describe... Maybe your commit aims to fix this? FYI, this error seems typical of a |
|
The issue with all failing is the version of the pico-sdk here, this is not aimed to fix that. |
|
Thanks! Just wanted to be sure these build issues were expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow caching was not working as intended, fail-fast caused fail of all jobs when one build failed.
This should now properly cache submodules and attempts to build all samples regardless of one failure.