fix(vite): vite 8 rolldown integration enforces strict type checking - #1152
Merged
Conversation
…checking for moduleSideEffects value `moduleSideEffects` cannot return a number (this sometimes would return `0` which breaks rolldown). ``` Error: Value is none of these types `bool`, `String`, on BindingHookTransformOutput.moduleSideEffects ```
🦋 Changeset detectedLatest commit: efa370a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for m-css ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for vite 8. The new rolldown integration introduced strict type checking for
moduleSideEffects.moduleSideEffectscannot return a number (this sometimes would return0🙃).Motivation and Context
i like using these tools
How Has This Been Tested?
passes tests locally, this is not tested
Types of changes
Checklist: