update dehydrated to 0.5.0#1
Closed
stenius wants to merge 1 commit intotjcelaya:fix/55-letsencrypt-agreement-urlfrom
Closed
update dehydrated to 0.5.0#1stenius wants to merge 1 commit intotjcelaya:fix/55-letsencrypt-agreement-urlfrom
stenius wants to merge 1 commit intotjcelaya:fix/55-letsencrypt-agreement-urlfrom
Conversation
Owner
|
Thanks for the PR but it would make more sense to open it against autopilotpattern/nginx. We'll get it merged there once we've had a chance to test. |
Owner
|
I'll test this fix and prefer it over autopilotpattern#56 if it works as expected. My decision to set the LICENSE url in the configs in that PR was based on uncertainty about the following comment in dehydrated 0.4.0:
|
Author
|
I already had an account so o haven't tested that flow yet. I set the
private account key in consul
…On Thu, Jan 18, 2018, 12:58 PM Tomas Celaya ***@***.***> wrote:
I'll test this fix and prefer it over autopilotpattern/nginx#56
<autopilotpattern#56> if it works as
expected. My decision to set the LICENSE url in the configs in that PR was
based on uncertainty about the following comment in dehydrated 0.4.0
<https://github.com/lukas2511/dehydrated/releases/tag/v0.4.0>:
dehydrated now asks you to read and accept the CAs terms of service before
creating an account
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARU8VZdnwUvn2eRN5jjDZD7RSjaMYLeks5tL5RCgaJpZM4RjWBh>
.
|
Owner
|
Mind if I cherry-pick your commit into a PR on autopilotpattern/nginx or do you want to open the PR yourself? |
Author
|
@tjcelaya not at all. It'd be awesome if you got this code in the main repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.