Skip to content

Conversation

@ElijahFeldman7
Copy link

Proposed changes

  • title

Brief description of rationale

closes #1863

@ElijahFeldman7 ElijahFeldman7 requested a review from a team as a code owner December 23, 2025 17:09
@ElijahFeldman7 ElijahFeldman7 force-pushed the dev branch 2 times, most recently from aa77ea6 to 0dee7d4 Compare December 23, 2025 17:33
@coveralls
Copy link

coveralls commented Dec 23, 2025

Coverage Status

coverage: 79.258% (+0.001%) from 79.257%
when pulling ea120a8 on ElijahFeldman7:dev
into b1d53dc on tjcsl:dev.

Copy link
Member

@shrysjain shrysjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Elijah, good work so far! A couple changes to make:

Right now, when an activity is marked as hidden it does not show up for students in the eighth signup page, but the block can still be seen from the activity page (eighth/activity/<id>). Through this students can also sign up for hidden activities which defeats the purpose. Can you make it so the scheduled block is also not visible here until the appropriate date has passed?

image

This block has the activity marked as hidden and is not visible from signup but is visible from the activity page when logged in as a student

Also, the functionality for adding a "hidden until" date in eighth admin (eighth/admin/scheduling/schedule) seems to work, but after clicking the save button the date no longer shows in the text area whereas things like comments, checkmarks, e.t.c. do persist. Can you figure out why this is happening and fix that as well.

Screenshot 2025-12-23 at 10 42 43 PM

I set a hidden until date and saved but it does not show

Other than that, great work and this should be pretty close to being complete :)

@ElijahFeldman7
Copy link
Author

i think these should be fixed now ^, lmk if you want any other changes

Copy link
Member

@aarushtools aarushtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Elijah,
Good work on this issue so far, just a few more things on top of what Shreyas said:
image
Can you format this tooltip text to separate the date and time better (and on a 12 HR clock). Also, the hidden badge has the same color as 2-day - can you make it have a unique styling (but use bland colors)
Also, can you prevent add_user from going through if the activity is hidden

@ElijahFeldman7
Copy link
Author

ok this should be good now; i made the icon grey btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow 8th period activities to be scheduled but not seen

4 participants