Upgrade to newer aws-nitro-enclaves-cli #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr-tk
force-pushed
the
christian/aws-nitro-cli-bump1
branch
from
d3cbce5 to
4017517
Compare
|
Rebased on top of the now-merged #504 to fix build problems. |
…nor versions Additional steps: harmonize the libc minimum version
cr-tk
force-pushed
the
christian/aws-nitro-cli-bump1
branch
from
4017517 to
eee0eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
We rely on several AWS NSM crates. After a long break, AWS released a new version of
aws-nitro-enclaves-clithat we should adopt, see here for changelog information.Along the way
aws-nitro-enclaves-nsm-api, which is basically just a MSRV updateCargo.lockentriesThese changes move us closer to getting rid of the unmaintained
attycrate, which is now removed in most places through a switch toclap4.x that doesn't depend on it anymore. Unfortunately, one usage site remains withaws-nitro-enclaves-image-format, which still depends onclap3.x even in a recent version.The dependency changes bring a lot of review tasks:
17 of the completely new crates are
aws-*crates, which helps a bit to establish trustworthiness.At the moment,
aws-nitro-enclaves-clidoesn't have Cargo features we can disable, so this dependency load is hard to reduce from my perspective.How I Tested These Changes
Local unit tests.
This change needs thorough testing in various testing environments.
Pre merge check list