bugfix: incorrect raw byte conversion to string #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
This PR fixes an issue where decrypted private keys were incorrectly converted to UTF-8 strings instead of the expected hexadecimal format...The current implementation works for regular text like a mnemonic.
This change introduces a new flag in the
decrypt
command called--hex-output
which ensures that raw bytes are correctly converted as hexadecimal string representations.Test
(Don't worry below is a throwaway ETH account purely for testing)
Before:
After: