Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Gmail doesn't like gzip files and so I created this. I'm not sure if you got my email as it bounced back due to a policy violation.
think it's just about ready for someone else to take a look at it to see what makes sense and what doesn't. There are some things like the DataTables based table browser which is nice to have right in the plugin, but the server side PHP script depends on PHP-PDO extension which everyone may not have.
About skipping columns:
basically, since every column was being sent to processValue, I thought it made sense to do two checks before doing so: make sure the column is text-based, and two, before processValue has to rip through some of the huge serialized data, do a quick check and see if the domain/search string is at least in there.
There is still some slop in there, but I agree with you that it probably makes sense to focus on fixes first. I think that processvalue() and replace() are good to go. do_change() has a bunch of enhancements. All of the upfront "analysis/reporting" features are all fairly modular with individual methods (the JS a bit less so).
So, let me know what you think of this.
Best,
Mike
Mike