Rename ArrayConverter to DataConverter for better naming clarity #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created new DataConverter class with the same functionality - Marked ArrayConverter as @deprecated with delegation to DataConverter - Added DataConverterTest as copy of ArrayConverterTest - Maintained backward compatibility for existing users - All existing code continues to work with deprecation warnings This change addresses issue #217 by providing a more accurate class name that reflects the broader data conversion capabilities beyond just arrays. The deprecation approach allows for gradual migration across dependent projects. Fixes #217
NErinola
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ArrayConvertertoDataConverterto better reflect its purpose as a general data conversion utilityArrayConverteras a deprecated wrapper that delegates toDataConverterDataConverterclassProblem
The
ArrayConverterclass name was misleading since it handles conversion of various data types (integers, longs, BigIntegers, hex strings, etc.), not just arrays. The name suggested it was only for array operations when it's actually a comprehensive data conversion utility.Solution
DataConverterclass with identical functionalityArrayConverterwith clear migration path via@deprecatedannotationsFiles Changed
DataConverter.java- New class with all conversion functionalityArrayConverter.java- Now deprecated wrapper that delegates to DataConverterDataConverterTest.java- Complete test suite for new classMigration Guide
Existing code using
ArrayConverterwill continue to work but will show deprecation warnings. To migrate:Impact on Dependent Projects
This change provides a migration path for the 3,385 references to ArrayConverter across all TLS-Attacker projects:
Projects can migrate at their own pace while maintaining compatibility.
Fixes #217