Skip to content

Fix unused code and imports in test files #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ic0ns merged 1 commit into from
Jun 30, 2025
Merged

Fix unused code and imports in test files #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/test/java/de/rub/nds/modifiablevariable/ModifiableVariableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@

import static org.junit.jupiter.api.Assertions.*;

import de.rub.nds.modifiablevariable.biginteger.*;
import de.rub.nds.modifiablevariable.bytearray.*;
import de.rub.nds.modifiablevariable.integer.*;
import de.rub.nds.modifiablevariable.singlebyte.*;
import java.util.ArrayList;
import java.util.List;
import org.junit.jupiter.api.Test;
Expand Down
31 changes: 11 additions & 20 deletions ...ava/de/rub/nds/modifiablevariable/biginteger/BigIntegerExplicitValueModificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

import java.math.BigInteger;
import org.junit.jupiter.api.BeforeEach;
Expand Down Expand Up @@ -156,29 +156,20 @@ void testToString() {
/** Test constructor with null value */
@Test
void testConstructorWithNullValue() {
// Using try-catch because we expect an exception
try {
// Explicitly specify null as BigInteger to avoid ambiguity with copy constructor
BigInteger nullValue = null;
new BigIntegerExplicitValueModification(nullValue);
fail("Constructor should throw NullPointerException");
} catch (NullPointerException e) {
// Expected exception
assertTrue(e.getMessage().contains("null"));
}
assertThrows(
NullPointerException.class,
() -> {
new BigIntegerExplicitValueModification((BigInteger) null);
});
}

/** Test setExplicitValue with null value */
@Test
void testSetExplicitValueWithNullValue() {
// Using try-catch because we expect an exception
try {
b1.setExplicitValue(null);
// Should not reach here
fail("setExplicitValue should throw NullPointerException");
} catch (NullPointerException e) {
// Expected exception
assertTrue(e.getMessage().contains("null"));
}
assertThrows(
NullPointerException.class,
() -> {
b1.setExplicitValue(null);
});
}
}
32 changes: 11 additions & 21 deletions ...est/java/de/rub/nds/modifiablevariable/biginteger/BigIntegerSubtractModificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

import java.math.BigInteger;
import org.junit.jupiter.api.BeforeEach;
Expand Down Expand Up @@ -166,30 +166,20 @@ void testToString() {
/** Test constructor with null value */
@Test
void testConstructorWithNullValue() {
// Using try-catch because we expect an exception
try {
// Explicitly specify null as BigInteger to avoid ambiguity with copy constructor
BigInteger nullValue = null;
BigIntegerSubtractModification mod = new BigIntegerSubtractModification(nullValue);
// Should not reach here
fail("Constructor should throw NullPointerException");
} catch (NullPointerException e) {
// Expected exception
assertTrue(e.getMessage().contains("null"));
}
assertThrows(
NullPointerException.class,
() -> {
new BigIntegerSubtractModification((BigInteger) null);
});
}

/** Test setSubtrahend with null value */
@Test
void testSetSubtrahendWithNullValue() {
// Using try-catch because we expect an exception
try {
b1.setSubtrahend(null);
// Should not reach here
fail("setSubtrahend should throw NullPointerException");
} catch (NullPointerException e) {
// Expected exception
assertTrue(e.getMessage().contains("null"));
}
assertThrows(
NullPointerException.class,
() -> {
b1.setSubtrahend(null);
});
}
}
32 changes: 11 additions & 21 deletions src/test/java/de/rub/nds/modifiablevariable/biginteger/BigIntegerXorModificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

import java.math.BigInteger;
import org.junit.jupiter.api.BeforeEach;
Expand Down Expand Up @@ -162,30 +162,20 @@ void testToString() {
/** Test constructor with null value */
@Test
void testConstructorWithNullValue() {
// Using try-catch because we expect an exception
try {
// Explicitly specify null as BigInteger to avoid ambiguity with copy constructor
BigInteger nullValue = null;
new BigIntegerXorModification(nullValue);
// Should not reach here
fail("Constructor should throw NullPointerException");
} catch (NullPointerException e) {
// Expected exception
assertTrue(e.getMessage().contains("null"));
}
assertThrows(
NullPointerException.class,
() -> {
new BigIntegerXorModification((BigInteger) null);
});
}

/** Test setXor with null value */
@Test
void testSetXorWithNullValue() {
// Using try-catch because we expect an exception
try {
b1.setXor(null);
// Should not reach here
fail("setXor should throw NullPointerException");
} catch (NullPointerException e) {
// Expected exception
assertTrue(e.getMessage().contains("null"));
}
assertThrows(
NullPointerException.class,
() -> {
b1.setXor(null);
});
}
}