Fix SpotBugs NP_BOOLEAN_RETURN_NULL warnings #250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SpotBugs annotations dependency - Suppressed NP_BOOLEAN_RETURN_NULL warnings in BooleanExplicitValueModification and BooleanToggleModification - The null returns are intentional to preserve null-safety in the modification framework - Tests already verify the null handling behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
The SpotBugs tool was reporting NP_BOOLEAN_RETURN_NULL warnings for the
modifyImplementationHookmethods in bothBooleanExplicitValueModificationandBooleanToggleModificationclasses. These methods return null when the input is null, which is intentional behavior to preserve null-safety throughout the modification framework.The fix adds the SpotBugs annotations dependency and uses
@SuppressFBWarningsto suppress these specific warnings with appropriate justification.Test plan