llms: support SystemChatMessage in ChatMessageModel.ToChatMessage#1496
Open
llms: support SystemChatMessage in ChatMessageModel.ToChatMessage#1496
Conversation
ConvertChatMessageToModel writes the system type but ToChatMessage returned nil for it, breaking round-trips through stores such as the mongo chat history. Add the case and cover the round-trip with a test. Fixes tmc#1056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConvertChatMessageToModelserializes anyChatMessage(includingSystemChatMessage) into aChatMessageModel, butChatMessageModel.ToChatMessageonly handled the AI and Human cases and returnednilfor system messages. Callers such as the Mongo chat history (memory/mongo) could write a system message and silently lose it on read.This adds the
ChatMessageTypeSystemcase and a round-trip test covering AI, Human, and System messages.Fixes #1056
Test plan
go vet ./llms/...go test ./llms/passesTestChatMessageModelRoundTripexercises the AI/Human/System round-trip viaConvertChatMessageToModel→ToChatMessage