feat: add search for criteria and how to pages using Fuse JS package - #457
feat: add search for criteria and how to pages using Fuse JS package#457silverli wants to merge 7 commits into
Conversation
4fa615a to
68a27b2
Compare
|
@silverli I love this! Feedback in! I think a good enhancement for future work could include:
|
| font: var(--magentaa11y-typeset-body-xl-strong); | ||
| } | ||
|
|
||
| &__input { |
There was a problem hiding this comment.
@silverli I think a custom CSS :focus-visible offset might look better since the focus ring is butting up against he magenta outline-offset: -4px or something.
| const resultsString = resultCount === 1 ? 'No results found' : `${resultCount} result${resultCount !== 1 ? 's' : ''} found`; | ||
|
|
||
| return ( | ||
| <div className="searchbar"> |
There was a problem hiding this comment.
@silverli search landmark role opportunity here. role="search"
| </label> | ||
| <input | ||
| className="searchbar__input" | ||
| role="combobox" |
There was a problem hiding this comment.
@silverli I'm a tad worried we might see screen reader conflicts with the ARIA Combobox approach here because the ARIA Menu items have nested links which is a no-no - they can only be menuitems and not consist of focusable child controls. I suggest killing all Combobox ARIA and just rely on the live region for dynamic updates. This would include the removal of aria-expanded too.
2 participants
--
things to discuss:
--
Claude code was used to help generate code.