Skip to content

Fix so that Ignored properties are not included in parameters #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix so that Ignored properties are not included in parameters #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1227c81
Modified the overload of GetDynamicParameters that is used when a key…
balchen Aug 9, 2021
dc37b60
The critical piece of code to make the unit test for a List property …
balchen Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions DapperExtensions.Test/IntegrationTests/Async/SqlServer/CrudFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@ namespace DapperExtensions.Test.IntegrationTests.Async.SqlServer
[Parallelizable(ParallelScope.Self)]
public static class CrudFixture
{
[TestFixture]
public class InsertAsyncList : SqlServerBaseAsyncFixture
{
[Test]
public void InsertAsyncListWithIgnore()
{
var f = new Foo { FirstName = "Test", LastName = "Person", DateOfBirth = DateTime.Today, BarList = new List<Bar>() { new Bar { Name = "BarTest" } } };
_ = Db.Insert(f).Result;
}
}

[TestFixture]
public class InsertMethod : SqlServerBaseAsyncFixture
{
Expand Down
16 changes: 10 additions & 6 deletions DapperExtensions/DapperImplementor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,12 +557,16 @@ public DynamicParameters GetDynamicParameters<T>(IClassMapper classMap, T entity
return GetDynamicParameters(entity, classMap, sequenceIdentityColumn, foreignKeys, ignored, useColumnAlias);
}

public DynamicParameters GetDynamicParameters<T>(T entity, DynamicParameters dynamicParameters, IMemberMap keyColumn, bool useColumnAlias = false)
public DynamicParameters GetDynamicParameters<T>(IClassMapper classMap, T entity, IMemberMap keyColumn, bool useColumnAlias = false)
{
dynamicParameters ??= new DynamicParameters();
foreach (var prop in entity.GetType().GetProperties(BindingFlags.GetProperty | BindingFlags.Instance | BindingFlags.Public)
.Where(p => p.Name != keyColumn.Name))
AddParameter(entity, dynamicParameters, new MemberMap(prop), useColumnAlias);
var ignored = classMap.Properties.Where(x => x.Ignored).Select(p => p.MemberInfo).ToList();

var dynamicParameters = new DynamicParameters();

foreach (var prop in entity.GetType().GetProperties(BindingFlags.GetProperty | BindingFlags.GetField | BindingFlags.Instance | BindingFlags.Public)
.Where(p => p.Name != keyColumn.Name && !ignored.Contains(p)
))
dynamicParameters = AddParameter(entity, dynamicParameters, new MemberMap(prop), useColumnAlias);

return dynamicParameters;
}
Expand Down Expand Up @@ -695,7 +699,7 @@ protected dynamic InternalInsert<T>(IDbConnection connection, T entity, IDbTrans
var keyColumn = triggerIdentityColumn ?? identityColumn;
object keyValue;

dynamicParameters = GetDynamicParameters(entity, dynamicParameters, keyColumn, true);
dynamicParameters = GetDynamicParameters(classMap, entity, keyColumn, true);

if (triggerIdentityColumn != null)
{
Expand Down