Skip to content

fix: stop hook warnings when quality gates are disabled#37

Merged
tmustier merged 1 commit into
mainfrom
fix/hooks-enabled-notices
Mar 27, 2026
Merged

fix: stop hook warnings when quality gates are disabled#37
tmustier merged 1 commit into
mainfrom
fix/hooks-enabled-notices

Conversation

@tmustier
Copy link
Copy Markdown
Owner

Summary

  • distinguish hook enablement from the presence of an enqueue callback in leader inbox polling
  • only enqueue hook events and qualify completion copy when hooks are actually enabled
  • add smoke coverage for both the per-task and batch-complete notification paths

Testing

  • npm run typecheck
  • npm run lint
  • npm run smoke-test

@tmustier
Copy link
Copy Markdown
Owner Author

Findings

No substantive findings. The change correctly decouples “hooks are wired” from “hooks are enabled,” updates both all-done notification paths, and adds smoke coverage for the disabled-hooks edge case in both per-task and batch-complete leader messages.

Verdict

correct — no P0-P2 issues found; the fix addresses the reported root cause without introducing an obvious regression, and the added tests cover the key notification paths.

@tmustier tmustier merged commit b39282e into main Mar 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant