-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline guard
in api.ts
#64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynn
commented
Jan 9, 2025
lynn
commented
Jan 9, 2025
uakci
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks for the contribution =:3!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a case where duplication is cheaper than the wrong abstraction. Not that guard() is wrong per se, but explicitly writing out each check will make the API functions easier to type (in the TypeScript sense) and easier to follow (less "callback hell" / it's completely clear what gets checked where in what order).
This will also help turn this file into a (testable!)
ToaduaApi
class. Right nowchecks.goodid
depends onindex_of
which depends onstore
which is a global. Eventually it'll want to be something likethis.goodid
which usesthis.store
. And this refactor will be easier to reason about without having to deal with the overly-abstractguard
.For now, I've just tried to mechanically repace every entry like:
with a simple if-return like:
Hopefully, this sets up a future PR to get rid of
ret()
and completely eliminate the continuation-passing style from the API.