Add utility to construct artificial interest fields from detected features#566
Add utility to construct artificial interest fields from detected features#566Sven-248 wants to merge 4 commits intotobac-project:RC_v1.6.xfrom
Conversation
Linting results by Pylint:Your code has been rated at 8.36/10 (previous run: 8.37/10, -0.01) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.6.x #566 +/- ##
=============================================
+ Coverage 64.86% 65.01% +0.14%
=============================================
Files 27 28 +1
Lines 4047 4110 +63
=============================================
+ Hits 2625 2672 +47
- Misses 1422 1438 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, @Sven-248 . Can we put this on the agenda for the dev meeting Friday? I'm curious to learn more of the background on this. Some stylistic notes:
|
fsenf
left a comment
There was a problem hiding this comment.
Dear @Sven-248 ,
thank you for your contributions. I have been looking for more general things first.
Could you please provide an updated version of the features_to_field.py module with
- refactoring applied such that no nested functions appear
- added docstrings
This would help to dive deeper in the next step. Please re-request my review once you are ready.
This PR handles #540 and introduces a new utility function features_to_interest_field that reconstructs an artificial interest field from a feature table (e.g. output of tobac feature detection).
The function places blobs at the detected feature positions and generates a corresponding field on a given template grid. Blob amplitude can be derived from a feature property and blob size can be estimated from feature area.