Fix load_private_key for ECDSA keys #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofay
force-pushed
the
fix-ecdsa
branch
3 times, most recently
from
a5bae91 to
03f82f5
Compare
Previously it would return an incorrect signature verification algorithm, which would cause verification to fail. Add tests using rcgen for a variety of key algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would return an incorrect signature verification algorithm, which would cause verification to fail.
The tests have been overhauled to use rustls and our own provider, rather than openssl, with a variety of key algorithms.
Also added ED25519 to the TLS 1.2 ECDSA signing algs fix the new tests with an ED25519 algorithm.