Fix expected timestamp values in integration test - #235
Merged
Conversation
The Cloud Spanner emulator no longer truncates the nanosecond part of TIMESTAMP values in change stream records, so the test's expected values (truncated to seconds) no longer match the actual output. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018vkB4oSYPTcopeMSJ9M4hZ
toga4
marked this pull request as ready for review
September 9, 2026 00:23
toga4
enabled auto-merge
September 9, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSubscriber_DataChangeRecordfails because the Cloud Spanner emulatorno longer truncates the nanosecond part of
TIMESTAMPvalues in changestream records. The test inserts a timestamp with nanosecond precision
(
2023-12-31T23:59:59.999999999Z), but the expected values were truncatedto
2023-12-31T23:59:59Z, matching an older emulator behavior.Changes
Timestamp/TimestampArrayvalues inintegration_test.goto keep the nanosecond precision.Testing
go test ./...🤖 Generated with Claude Code
https://claude.ai/code/session_018vkB4oSYPTcopeMSJ9M4hZ