Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance base font size display in settings tab #2886

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Jun 19, 2024

  • Now base font size's reference will be displayed directly outside in the settings tab
  • when the referenced token is deleted or invalid, it shall display the broken link in red
  • Resolves Show base font size token even outside #2875
Screenshot 2024-06-20 at 00 36 13 Screenshot 2024-06-20 at 00 36 44

In dark mode:

Screenshot 2024-06-20 at 11 46 09 Screenshot 2024-06-20 at 11 46 41

@akshay-gupta7 akshay-gupta7 requested a review from six7 June 19, 2024 18:59
@akshay-gupta7 akshay-gupta7 self-assigned this Jun 19, 2024
Copy link

changeset-bot bot commented Jun 19, 2024

⚠️ No Changeset found

Latest commit: 541d742

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akshay-gupta7 akshay-gupta7 linked an issue Jun 19, 2024 that may be closed by this pull request
@akshay-gupta7 akshay-gupta7 requested a review from six7 June 20, 2024 06:11
@six7 six7 merged commit c5bd238 into release-139 Jun 20, 2024
7 of 8 checks passed
@six7 six7 deleted the enhance-base-font-size-display branch June 20, 2024 08:18
@six7 six7 added the 2.0-rc8 label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show base font size token even outside
2 participants