Revert manage theme followup #2889
Conversation
|
| > | ||
| Add group | ||
| {t('addGroup')} |
There was a problem hiding this comment.
The seems to be unnecessary, and feels like an antipattern to use HTML characters in locale files. Tried resizing the plugin to minimum width and the button stayed on one line.
There was a problem hiding this comment.
agree should also be solveable with css
…kens-studio/figma-plugin into fix/2880-revert-manage-theme-followup
…kens-studio/figma-plugin into fix/2880-revert-manage-theme-followup
| > | ||
| Add group | ||
| {t('addGroup')} |
There was a problem hiding this comment.
agree should also be solveable with css
| @@ -117,7 +127,8 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props | |||
| autofocus | |||
| data-testid="create-or-edit-theme-form--group--name" | |||
| {...register('group')} | |||
| placeholder="Add group" | |||
| placeholder={t('addGroup')} | |||
| onKeyDown={handleKeyDown('group')} | |||
There was a problem hiding this comment.
Would this not be calling it all the time on any key down event? 🧐
| onKeyDown={handleKeyDown('group')} | |
| onKeyDown={() => handleKeyDown('group')} |
would that work?
There was a problem hiding this comment.
Changed the function handleKeyDown to handleGroupKeyDown, the 'group' argument here is redundant since the function is only being used in one place.
packages/tokens-studio-for-figma/src/app/components/ManageThemesModal/ManageThemesModal.tsx
Show resolved
Hide resolved
Why does this PR exist?
Resolve comments in #2883
Closes #2900
What does this pull request do?
Testing this change
Theme: <Theme Name>thenManage themes >Escand confirm that the modal isn't closedCancelandConfirmbuttons work correctlyCreate new groupEscdoesn't close the modalClosebutton works correctly and isn't blockedAdditional Notes (if any)
After