Add new tests for JoinSet, JoinMap, TaskTracer and LocalRuntime #7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
added
A-tokio-util
ADD-SP
reviewed
Sep 15, 2025
Comment on lines
+122
to
+133
| rt.block_on(local.run_until(async { | ||
| let thread_result = std::thread::spawn(|| { | ||
| let panic_result = panic::catch_unwind(|| { | ||
| let _jh = tokio::task::spawn_local(async { | ||
| println!("you will never see this line"); | ||
| }); | ||
| }); | ||
| assert!(panic_result.is_err(), "Expected panic, but none occurred"); | ||
| }) | ||
| .join(); | ||
| assert!(thread_result.is_ok(), "Thread itself panicked unexpectedly"); | ||
| })); |
There was a problem hiding this comment.
There are many nested closure, and it took me longer time to understand, could you add a comment to describe what this test does?
Comment on lines
+383
to
+388
| // Drive a `LocalSet` on top of a `LocalRuntime` and verify that tasks | ||
| // queued with `JoinSet::spawn_local_on` run to completion only after the | ||
| // `LocalSet` starts. | ||
| #[cfg(tokio_unstable)] | ||
| #[test] | ||
| fn spawn_local_on_local_runtime() { |
There was a problem hiding this comment.
verify that tasks queued with
JoinSet::spawn_local_onrun to completion only after theLocalSetstarts.
Why do we need to verify this behavior?
| } | ||
|
|
||
| // Dropping a `JoinSet` created inside a **LocalRuntime** | ||
| // must abort every still-running `!Send` task that was |
There was a problem hiding this comment.
must abort every still-running
!Sendtask that was
Does Send or not matter?
ADD-SP
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7562
Motivation
Improve the test coverage of task containers on LocalRuntime
Solution
Added new tests for JoinSet, JoinMap, TaskTracer