tokio-uitls: from_parts() for FramedWrite and FramedRead #7763
+138
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
from_parts()forFramedWriteandFramedRead.Motivation
Thanks to #7566,
FramedWriteandFramedReadcan be transformed intoFramedParts, but there is no way to create them back from parts, or to transformFramedintoFramedReadorFramedWritewithout losing progress in buffers.My original problem was splitting
Framedinto bothFramedReadandFramedWrite, to swap the codec for one of them withmap_codec. I wish we could have something likeinto_splitforFramed:But cloning of the codec doesn't feel right here. So, with
from_parts, a user will have more control over the reader and writer reconstruction.Solution
Implement
from_parts()forFramedWriteandFramedRead, which builds those structures fromFramedPartsand preserves internal buffers.