Skip to content

Commit fb78cdc

Browse files
committed
Drop unnecessary if branch
1 parent cc75cbd commit fb78cdc

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

examples/examples/sloggish/sloggish_subscriber.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,7 @@ impl Subscriber for SloggishSubscriber {
228228
let spans = self.spans.lock().unwrap();
229229
let data = spans.get(span_id);
230230
let parent = data.and_then(|span| span.parent.as_ref());
231-
if stack.iter().any(|id| id == span_id) {
232-
// We are already in this span, do nothing.
233-
} else {
231+
if !stack.iter().any(|id| id == span_id) {
234232
let indent = if let Some(idx) = stack
235233
.iter()
236234
.position(|id| parent.map(|p| id == p).unwrap_or(false))
@@ -248,8 +246,7 @@ impl Subscriber for SloggishSubscriber {
248246
self.print_kvs(&mut stderr, data.kvs.iter().map(|(k, v)| (k, v)), "")
249247
.unwrap();
250248
}
251-
#[allow(clippy::write_with_newline)]
252-
write!(&mut stderr, "\n").unwrap();
249+
writeln!(&mut stderr).unwrap();
253250
}
254251
}
255252

@@ -270,8 +267,7 @@ impl Subscriber for SloggishSubscriber {
270267
comma: false,
271268
};
272269
event.record(&mut visitor);
273-
#[allow(clippy::write_with_newline)]
274-
write!(&mut visitor.stderr, "\n").unwrap();
270+
writeln!(&mut visitor.stderr).unwrap();
275271
}
276272

277273
#[inline]

0 commit comments

Comments
 (0)