Skip to content

appender: Add fallback to file creation date #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2025
Merged

appender: Add fallback to file creation date #3000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
724f3f9
appender: Add fallback to file creation date
kaffarell Jun 7, 2024
8635ea3
Fix formatting
jplatte Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions tracing-appender/src/rolling.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use std::{
path::{Path, PathBuf},
sync::atomic::{AtomicUsize, Ordering},
};
use time::{format_description, Date, Duration, OffsetDateTime, Time};
use time::{format_description, Date, Duration, OffsetDateTime, PrimitiveDateTime, Time};

mod builder;
pub use builder::{Builder, InitError};
Expand Down Expand Up @@ -676,7 +676,24 @@ impl Inner {
return None;
}

let created = metadata.created().ok()?;
let created = metadata.created().ok().or_else(|| {
let mut datetime = filename;
if let Some(prefix) = &self.log_filename_prefix {
datetime = datetime.strip_prefix(prefix)?;
datetime = datetime.strip_prefix('.')?;
}
if let Some(suffix) = &self.log_filename_suffix {
datetime = datetime.strip_suffix(suffix)?;
datetime = datetime.strip_suffix('.')?;
}

Some(
PrimitiveDateTime::parse(datetime, &self.date_format)
.ok()?
.assume_utc()
.into(),
)
})?;
Some((entry, created))
})
.collect::<Vec<_>>()
Expand Down
Loading