-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BOOT_DIR parameter #214
base: master
Are you sure you want to change the base?
Conversation
82ec3bc
to
e920c21
Compare
fi | ||
|
||
rsync -a "${BOOT}"/ "${MOUNT_POINT}" | ||
rsync -a --no-o --no-g "${BOOT}"/ "${MOUNT_POINT}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it's related to a different task. Why did you decide to add --no-o
and --no-g
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise I get
rsync: chown "/home/denis/Documents/git/pieman/build/e79a5a1f-7d52-4d37-ace1-d7339b23e68a/mount_point/." failed: Operation not permitted (1)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1183) [sender=3.1.1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase the branch on master
because the current issue with Travis is already solved there.
e920c21
to
fc24700
Compare
Please make sure all below checkboxes in the Mandatory section have been checked before submitting your PR (also don't forget to pay attention to the Depending on Circumstances section)
Mandatory
Add something
,Remove something
,Fix something
, etc.).Depending on Circumstances
Some of the items in the section become mandatory if you are a first-time contributor and/or your changes are relevant to the items.
README.md
.pieman/README.md
.pieman/setup.py
,pieman/pieman/__init__.py
andessentials.sh
.AUTHORS.md
.