feat(nx): convert to eslint flat config (spartan-ng#265)

* feat(nx): convert to eslint flat config

* fix(nx): use .cjs extensions for flat config to work

---------

Co-authored-by: Robin Goetz <[email protected]>

.vscode/settings.json

@@ -1,3 +1,5 @@
 {
-	"eslint.validate": ["json"]
+	"eslint.validate": ["json"],
+	"eslint.experimental.useFlatConfig": true,
+	"eslint.format.enable": true
 }

apps/app/eslint.config.cjs

@@ -0,0 +1,42 @@
+const { FlatCompat } = require('@eslint/eslintrc');
+const baseConfig = require('../../eslint.config.cjs');
+const js = require('@eslint/js');
+
+const compat = new FlatCompat({
+	baseDirectory: __dirname,
+	recommendedConfig: js.configs.recommended,
+});
+
+module.exports = [
+	...baseConfig,
+	...compat
+		.config({ extends: ['plugin:@nx/angular', 'plugin:@angular-eslint/template/process-inline-templates'] })
+		.map((config) => ({
+			...config,
+			files: ['**/*.ts'],
+			rules: {
+				'@angular-eslint/no-host-metadata-property': 0,
+				'@angular-eslint/directive-selector': [
+					'error',
+					{
+						type: 'attribute',
+						prefix: 'spartan',
+						style: 'camelCase',
+					},
+				],
+				'@angular-eslint/component-selector': [
+					'error',
+					{
+						type: 'element',
+						prefix: 'spartan',
+						style: 'kebab-case',
+					},
+				],
+			},
+		})),
+	...compat.config({ extends: ['plugin:@nx/angular-template'] }).map((config) => ({
+		...config,
+		files: ['**/*.html'],
+		rules: {},
+	})),
+];

apps/app/project.json

@@ -3,6 +3,8 @@
 	"$schema": "../../node_modules/nx/schemas/project-schema.json",
 	"projectType": "application",
 	"sourceRoot": "apps/app/src",
+	"tags": [],
+	"implicitDependencies": [],
 	"targets": {
 		"build": {
 			"dependsOn": ["^build"],
@@ -77,7 +79,5 @@
 			},
 			"dependsOn": ["build"]
 		}
-	},
-	"tags": [],
-	"implicitDependencies": []
+	}
 }

apps/trpc-app-e2e/eslint.config.js

@@ -0,0 +1,16 @@
+const baseConfig = require('../../eslint.config.js');
+
+module.exports = [
+	...baseConfig,
+	{
+		files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
+		rules: {},
+	},
+	{
+		files: ['src/plugins/index.js'],
+		rules: {
+			'@typescript-eslint/no-var-requires': 'off',
+			'no-undef': 'off',
+		},
+	},
+];

apps/trpc-app-e2e/project.json

@@ -3,6 +3,8 @@
 	"$schema": "../../node_modules/nx/schemas/project-schema.json",
 	"sourceRoot": "apps/trpc-app-e2e/src",
 	"projectType": "application",
+	"tags": [],
+	"implicitDependencies": ["app"],
 	"targets": {
 		"vitest": {
 			"executor": "@nx/vite:test"
@@ -18,7 +20,5 @@
 			"executor": "@nx/eslint:lint",
 			"outputs": ["{options.outputFile}"]
 		}
-	},
-	"tags": [],
-	"implicitDependencies": ["app"]
+	}
 }

apps/ui-storybook-e2e/eslint.config.js

@@ -0,0 +1,17 @@
+const { FlatCompat } = require('@eslint/eslintrc');
+const baseConfig = require('../../eslint.config.js');
+const js = require('@eslint/js');
+
+const compat = new FlatCompat({
+	baseDirectory: __dirname,
+	recommendedConfig: js.configs.recommended,
+});
+
+module.exports = [
+	...baseConfig,
+	...compat.extends('plugin:cypress/recommended'),
+	{
+		files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
+		rules: {},
+	},
+];

apps/ui-storybook-e2e/project.json

@@ -3,6 +3,8 @@
 	"$schema": "../../node_modules/nx/schemas/project-schema.json",
 	"sourceRoot": "apps/ui-storybook-e2e/src",
 	"projectType": "application",
+	"tags": ["scope:e2e"],
+	"implicitDependencies": ["ui-storybook"],
 	"targets": {
 		"e2e": {
 			"executor": "@nx/cypress:cypress",
@@ -21,7 +23,5 @@
 			"executor": "@nx/eslint:lint",
 			"outputs": ["{options.outputFile}"]
 		}
-	},
-	"tags": ["scope:e2e"],
-	"implicitDependencies": ["ui-storybook"]
+	}
 }

eslint.config.cjs

@@ -0,0 +1,69 @@
+const { FlatCompat } = require('@eslint/eslintrc');
+const nxEslintPlugin = require('@nx/eslint-plugin');
+const js = require('@eslint/js');
+
+const compat = new FlatCompat({
+	baseDirectory: __dirname,
+	recommendedConfig: js.configs.recommended,
+});
+
+module.exports = [
+	{ plugins: { '@nx': nxEslintPlugin } },
+	{
+		files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
+		rules: {
+			'@nx/enforce-module-boundaries': [
+				'error',
+				{
+					enforceBuildableLibDependency: true,
+					allow: [],
+					depConstraints: [
+						{
+							sourceTag: '*',
+							onlyDependOnLibsWithTags: ['*'],
+						},
+					],
+				},
+			],
+		},
+	},
+	...compat.config({ extends: ['plugin:@nx/typescript'] }).map((config) => ({
+		...config,
+		files: ['**/*.ts', '**/*.tsx'],
+		rules: {},
+	})),
+	...compat.config({ extends: ['plugin:@nx/javascript'] }).map((config) => ({
+		...config,
+		files: ['**/*.js', '**/*.jsx'],
+		rules: {},
+	})),
+	...compat.config({ env: { jest: true } }).map((config) => ({
+		...config,
+		files: ['**/*.spec.ts', '**/*.spec.tsx', '**/*.spec.js', '**/*.spec.jsx'],
+		rules: {},
+	})),
+	...compat.config({ parser: 'jsonc-eslint-parser' }).map((config) => ({
+		...config,
+		files: ['**/*.json'],
+		rules: {
+			'@nx/dependency-checks': [
+				'error',
+				{
+					buildTargets: ['build'],
+					checkMissingDependencies: true,
+					checkObsoleteDependencies: true,
+					checkVersionMismatches: true,
+					ignoredDependencies: [
+						'jest-preset-angular',
+						'jest-axe',
+						'@testing-library/jest-dom',
+						'rxjs',
+						'@spartan-ng/ui-icon-helm',
+						'@spartan-ng/ui-button-helm',
+						'@spartan-ng/ui-avatar-brain',
+					],
+				},
+			],
+		},
+	})),
+];

libs/cli/eslint.config.js

@@ -0,0 +1,29 @@
+const { FlatCompat } = require('@eslint/eslintrc');
+const baseConfig = require('../../eslint.config.js');
+const js = require('@eslint/js');
+
+const compat = new FlatCompat({
+	baseDirectory: __dirname,
+	recommendedConfig: js.configs.recommended,
+});
+
+module.exports = [
+	...baseConfig,
+	{
+		files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
+		rules: {},
+	},
+	{
+		files: ['**/*.ts', '**/*.tsx'],
+		rules: {},
+	},
+	{
+		files: ['**/*.js', '**/*.jsx'],
+		rules: {},
+	},
+	...compat.config({ parser: 'jsonc-eslint-parser' }).map((config) => ({
+		...config,
+		files: ['./package.json', './executors.json'],
+		rules: { '@nx/nx-plugin-checks': 'error' },
+	})),
+];