Disable escaping from namespaces for inner functions (#208) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be invalid to reference a local variable from a different function, and the check is a work in progress right now. For the purpose of catching invalid variable references, a set of new 'function scopes' has been introduced into Context. Every variable will keep track of its function scope. A variable can be referenced as a value if and only if its function scope is equal to the current function scope, or its function scope is the global scope.
* added Context::addVariable, which takes of the function scopes, and routed all Namespace::addVariable calls to this function. * modified Context::getVariable to take care of the function scopes
ChengCat
changed the title
|
Thanks for this, it looks good. The only change I'd like to make is to drop the |
|
Thanks for the feedback. I originally added that error, because my mental model is that the variable is in the scope, but can't be referenced as a value. (Function scope is viewed as a compiler implementation detail.) |
|
Yep, these changes look good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace escaping behaviour has been removed, and a new machanism for checking invalid variable reference is added.
This is mostly done, and the error reporting could be improved:
error-src/anonymous-scopes.dtgenerates two "can't reference variable in a different function" errors.I tackle this issue (#208) first instead of #201, because this seems to be easier, and it's more urgent for my use.