Skip to content

Include /src files in published packages (base, validate) #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thiagoelg
Copy link

While working with this library I noticed that for the base and validate packages the webpack was throwing warnings related to the source maps referencing missing files:

WARNING in ../../node_modules/.pnpm/@[email protected]/node_modules/@kubernetes-models/validate/dist/index.js
Module Warning (from ../../node_modules/.pnpm/[email protected][email protected]/node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/thiagolugli/ibm/kie-tools/node_modules/.pnpm/@[email protected]/node_modules/@kubernetes-models/validate/src/index.ts' file: Error: ENOENT: no such file or directory, open '/Users/thiagolugli/ibm/kie-tools/node_modules/.pnpm/@[email protected]/node_modules/@kubernetes-models/validate/src/index.ts'

and

WARNING in ../../node_modules/.pnpm/@[email protected]/node_modules/@kubernetes-models/base/dist/model.js
Module Warning (from ../../node_modules/.pnpm/[email protected][email protected]/node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/thiagolugli/ibm/kie-tools/node_modules/.pnpm/@[email protected]/node_modules/@kubernetes-models/base/src/model.ts' file: Error: ENOENT: no such file or directory, open '/Users/thiagolugli/ibm/kie-tools/node_modules/.pnpm/@[email protected]/node_modules/@kubernetes-models/base/src/model.ts'

My suspicion is that since the /src directory is not published with those packages the source-map-loader can't reference them.

The solution proposed here is to publish the /src directory.

@tiagobento
Copy link

Hi @tommy351, any chance you can take a look at this PR? Thanks a lot in advance!

@tiagobento
Copy link

@tommy351 Hi! Could you please take a look at this PR? It's pretty simple and improved the experience when developing apps that depend on it. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants