Updating handling of sample priority extraction #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the sample priority extraction logic to match what is provided in Datadog's SDKs. I.e. any positive integer value is treated as a true value, any 0 or negative integer value is treated as a false value. Non-integer values cause context extraction to fail with an error.
|
For reference, here's how Datadog's SDK in go handles extraction of the sampling priority header |
tonglil
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the sample priority extraction logic to match what is provided in Datadog's SDKs. I.e. any positive integer value is treated as a true value, any 0 or negative integer value is treated as a false value. Non-integer values cause context extraction to fail with an error.
This partially addresses #17 in that extraction will now work correctly for values > 1; it does not propagate the non 0/1 values to any outgoing trace context.