fix(forms): fix wrong references in types in picasso-forms

[denieler]

Description

We have currently an issue in the types of picasso-forms, that come types are imported incorrectly from @toptal/picasso/src/**. Looks like this is happening because of an issue in tsc - microsoft/TypeScript#34793.

So currently this code:

import { ButtonProps } from '@toptal/picasso'
export type Props = Omit<ButtonProps, 'type'>
export const SubmitButton = (props: Props) => {

got transformed by tsc into:

import { ButtonProps } from '@toptal/picasso';
export declare type Props = Omit<ButtonProps, 'type'>;
export declare const SubmitButton: {
    (props: Pick<Pick<import("@toptal/picasso/src/Button").Props, "color" | "hidden" | "size" | "style" | "icon" | "active" | "disabled" | "children", ...

which is wrong. But after modifying ButtonProps somehow - looks like tsc understand better what we want from it. I haven't found yet a better fix

[denieler]

we don't need OmitInternalProps anymore, because Button is using useStyles already 👍

[havenchyk]

which is wrong

but what exactly went wrong?

[denieler]

which is wrong

but what exactly went wrong?

This was the issue - https://github.com/toptal/staff-portal/pull/849#discussion_r428988456
@toptal/picasso/src/Button - this link is not correct, because we don't have src folder in Picasso package after the release

[toptal-devbot]

🎉 Last commit is successfully deployed 🎉

Demo is available on:

• https://picasso.toptal.net/fx-fix-picasso-forms-types/

Your davinci-bot 🚀