Adopted LRU from https://github.com/cluck, tested, fixed some issues (fix of issue#20) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… especially multithreading access to LRU which caused fails
…tion even for release of the bundle
wwwenca
changed the title
|
How did you test multi-threading? As in, do you have a simple testcase/usage that will result in fuse using more than one thread? |
|
It has been a while, so i am not sure of the exact steps. Anyway, as far as I remember.... It was something like it was running ok in the foreground, but when I run it in the background it failed almost immediately. I started with debugging and found out that it behaved like same LRU item was used twice which I supposed to be a multithreading issue. Adding the critical sections solved the problem and stabilised the run. Then I used it for copying some large backups from the sparsebundles. They were ok, as i did compare them to the original files. Since than i had no more chance to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have adopted LRU idea from https://github.com/cluck, tested, fixed some issues, especially multithreading access to LRU which caused fails. This should fix issue#20. (I have been able to copy like 100G+ with this version on my Synology NAS, so I believe it works)