Enhance parsing of Accept-Language quality values #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Can you add a simple test case for this functionality to |
|
@bdarnell Added a test case with all tests passing. |
bdarnell
reviewed
Feb 5, 2022
|
Accept-language parsing was improved in #3068 so I think this PR is no longer needed; if there was something here that's not covered by that PR feel free to open a new one. |
|
no, this is an additional MR on top of #3068 - and already rebased up on it. please reopen. |
|
Ah, OK. In that case my comment about the deeply-nested generator expression inside a for loop expression still stands. |
The following cases were not possible: "Accept-Language: en-US; foo=bar; q=0.9" "Accept-Language: en-US; q = 0.9"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse HTTP syntax correctly:
Accept-Language: en-US ; foo=bar; q=2.0was not possible and is now possible.